stevedlawrence commented on code in PR #821:
URL: https://github.com/apache/daffodil/pull/821#discussion_r1038421483
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/DataProcessor.scala:
##########
@@ -372,7 +372,7 @@ class DataProcessor private (
validationMode match {
case ValidationMode.Full | ValidationMode.Custom(_) =>
val bos = new java.io.ByteArrayOutputStream()
- val xmlOutputter = new XMLTextInfosetOutputter(bos, false)
+ val xmlOutputter = new XMLTextInfosetOutputter(bos, false,
tunables.xmlOutputStyle)
Review Comment:
Good point, I hadn't thought about the TDML runner.
Though, one thing to consider is that the TDML runner is somewhat lax about
what it compares. For example, I think elements look the same to TDML XML
comparison regardless if CDATA is used or not.
Aslo, TDML runner uses all InfosetOutputters and compares the results. So,
for example, if a TDML test configures an XMLTextInfosetOutputter to use UTF-8
but not other InfosetOutputters, then things might not compare the same.
These kinds of issues can probably be resolved, but we do also have the (now
faster) CLI integration tests and API unit tests if it's difficult.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
