mbeckerle commented on code in PR #891:
URL: https://github.com/apache/daffodil/pull/891#discussion_r1050016910
##########
BUILD.md:
##########
@@ -59,35 +59,35 @@ environment variables `CC` and `AR` to the clang binaries'
names:
export CC=clang AR=llvm-ar
-However, Fedora has no [sbt][SBT] package in its own repositories.
-You'll have to install the latest [SBT] version following its
+However, Fedora has no [sbt] package in its own repositories.
+You'll have to install the latest [sbt] version following its
website's instructions.
Now you can build Daffodil from source and the sbt and daffodil
commands you type will be able to call the C compiler.
-## Ubuntu 20.04
+## Ubuntu
You can use the `apt` package manager to install most of the tools
needed to build Daffodil:
- sudo apt install build-essential clang-10 clang-format-10 default-jdk git
libmxml-dev
+ sudo apt install build-essential clang clang-format default-jdk git
libmxml-dev
If you want to use clang instead of gcc, you'll have to set your
environment variables `CC` and `AR` to the clang binaries' names:
- export CC=clang-10 AR=llvm-ar-10
+ export CC=clang AR=llvm-ar-14 # or llvm-ar-10 or whatever you have
-However, Ubuntu has no [sbt][SBT] package in its own repositories.
-You'll have to install the latest [SBT] version following its
+However, Ubuntu has no [sbt] package in its own repositories.
Review Comment:
This may not be true any longer. I got prompted to update sbt by the ubuntu
software updater recently.
##########
BUILD.md:
##########
@@ -19,15 +19,15 @@
Daffodil's build requirements include:
-* JDK 8 or higher
-* SBT 0.13.8 or higher
+* Java 8 or higher
+* sbt 0.13.8 or higher
* C compiler C99 or higher
* Mini-XML Version 3.0 or higher
-You will need the Java Software Development Kit ([JDK]) and the Scala
-Build Tool ([SBT]) to build Daffodil, run all tests, create packages,
-and more. You can install the latest [Java 11 LTS][JDK] version and
-the latest [SBT] version following their websites' instructions or
+You will need the Java Software Development Kit ([Java]) and the Scala
+Build Tool ([sbt]) to build Daffodil, run all tests, create packages,
+and more. You can install the latest [Java 11 LTS][Java] version and
Review Comment:
Why stipulate Java 11?
We should either say Java 8, or Java 8 (Java 11 and Java 17 are also
supported)
##########
BUILD.md:
##########
@@ -19,15 +19,15 @@
Daffodil's build requirements include:
-* JDK 8 or higher
-* SBT 0.13.8 or higher
+* Java 8 or higher
+* sbt 0.13.8 or higher
Review Comment:
Do we really support sbt this old? I don't want to even bother checking it.
##########
BUILD.md:
##########
@@ -59,35 +59,35 @@ environment variables `CC` and `AR` to the clang binaries'
names:
export CC=clang AR=llvm-ar
-However, Fedora has no [sbt][SBT] package in its own repositories.
-You'll have to install the latest [SBT] version following its
+However, Fedora has no [sbt] package in its own repositories.
+You'll have to install the latest [sbt] version following its
website's instructions.
Now you can build Daffodil from source and the sbt and daffodil
commands you type will be able to call the C compiler.
-## Ubuntu 20.04
+## Ubuntu
You can use the `apt` package manager to install most of the tools
needed to build Daffodil:
- sudo apt install build-essential clang-10 clang-format-10 default-jdk git
libmxml-dev
+ sudo apt install build-essential clang clang-format default-jdk git
libmxml-dev
If you want to use clang instead of gcc, you'll have to set your
environment variables `CC` and `AR` to the clang binaries' names:
- export CC=clang-10 AR=llvm-ar-10
+ export CC=clang AR=llvm-ar-14 # or llvm-ar-10 or whatever you have
-However, Ubuntu has no [sbt][SBT] package in its own repositories.
-You'll have to install the latest [SBT] version following its
+However, Ubuntu has no [sbt] package in its own repositories.
+You'll have to install the latest [sbt] version following its
website's instructions.
Now you can build Daffodil from source and the sbt and daffodil
commands you type will be able to call the C compiler.
## Windows 10
-Install the latest [Java 11 LTS][JDK] version and the latest [SBT]
+Install the latest [Java 11 LTS][Java] version and the latest [sbt]
Review Comment:
Java version issue again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
