tuxji commented on code in PR #891:
URL: https://github.com/apache/daffodil/pull/891#discussion_r1050078169
##########
BUILD.md:
##########
@@ -19,15 +19,15 @@
Daffodil's build requirements include:
-* JDK 8 or higher
-* SBT 0.13.8 or higher
+* Java 8 or higher
+* sbt 0.13.8 or higher
* C compiler C99 or higher
* Mini-XML Version 3.0 or higher
-You will need the Java Software Development Kit ([JDK]) and the Scala
-Build Tool ([SBT]) to build Daffodil, run all tests, create packages,
-and more. You can install the latest [Java 11 LTS][JDK] version and
-the latest [SBT] version following their websites' instructions or
+You will need the Java Software Development Kit ([Java]) and the Scala
+Build Tool ([sbt]) to build Daffodil, run all tests, create packages,
+and more. You can install the latest [Java 11 LTS][Java] version and
Review Comment:
No good reason to stipulate Java 11 except a wish people would leave Java 8
behind. I'll punt and just say "latest Java LTS" without any version number.
##########
BUILD.md:
##########
@@ -59,35 +59,35 @@ environment variables `CC` and `AR` to the clang binaries'
names:
export CC=clang AR=llvm-ar
-However, Fedora has no [sbt][SBT] package in its own repositories.
-You'll have to install the latest [SBT] version following its
+However, Fedora has no [sbt] package in its own repositories.
+You'll have to install the latest [sbt] version following its
website's instructions.
Now you can build Daffodil from source and the sbt and daffodil
commands you type will be able to call the C compiler.
-## Ubuntu 20.04
+## Ubuntu
You can use the `apt` package manager to install most of the tools
needed to build Daffodil:
- sudo apt install build-essential clang-10 clang-format-10 default-jdk git
libmxml-dev
+ sudo apt install build-essential clang clang-format default-jdk git
libmxml-dev
If you want to use clang instead of gcc, you'll have to set your
environment variables `CC` and `AR` to the clang binaries' names:
- export CC=clang-10 AR=llvm-ar-10
+ export CC=clang AR=llvm-ar-14 # or llvm-ar-10 or whatever you have
-However, Ubuntu has no [sbt][SBT] package in its own repositories.
-You'll have to install the latest [SBT] version following its
+However, Ubuntu has no [sbt] package in its own repositories.
Review Comment:
If you check your apt sources, you'll probably find the sbt project's apt
repository. When I updated this file, I checked again and there was still no
sbt package in Debian or Ubuntu apt repositories. BTW, I found out the reason
for that from sbt's Wikipedia page, which says:
> The sbt project is "bootstrapped" — it uses sbt to build itself, as many
compilers also do, and it considers that dogfooding is a positive feature. To
the Debian project, however, that is considered a circular dependency, that
they try to minimize. As a result, sbt is not yet in Debian.
##########
BUILD.md:
##########
@@ -59,35 +59,35 @@ environment variables `CC` and `AR` to the clang binaries'
names:
export CC=clang AR=llvm-ar
-However, Fedora has no [sbt][SBT] package in its own repositories.
-You'll have to install the latest [SBT] version following its
+However, Fedora has no [sbt] package in its own repositories.
+You'll have to install the latest [sbt] version following its
website's instructions.
Now you can build Daffodil from source and the sbt and daffodil
commands you type will be able to call the C compiler.
-## Ubuntu 20.04
+## Ubuntu
You can use the `apt` package manager to install most of the tools
needed to build Daffodil:
- sudo apt install build-essential clang-10 clang-format-10 default-jdk git
libmxml-dev
+ sudo apt install build-essential clang clang-format default-jdk git
libmxml-dev
If you want to use clang instead of gcc, you'll have to set your
environment variables `CC` and `AR` to the clang binaries' names:
- export CC=clang-10 AR=llvm-ar-10
+ export CC=clang AR=llvm-ar-14 # or llvm-ar-10 or whatever you have
-However, Ubuntu has no [sbt][SBT] package in its own repositories.
-You'll have to install the latest [SBT] version following its
+However, Ubuntu has no [sbt] package in its own repositories.
+You'll have to install the latest [sbt] version following its
website's instructions.
Now you can build Daffodil from source and the sbt and daffodil
commands you type will be able to call the C compiler.
## Windows 10
-Install the latest [Java 11 LTS][JDK] version and the latest [SBT]
+Install the latest [Java 11 LTS][Java] version and the latest [sbt]
Review Comment:
Removed 11 here too.
##########
BUILD.md:
##########
@@ -19,15 +19,15 @@
Daffodil's build requirements include:
-* JDK 8 or higher
-* SBT 0.13.8 or higher
+* Java 8 or higher
+* sbt 0.13.8 or higher
Review Comment:
Problem is, which version to put in? 1.0.0 or whatever? Easier to leave
0.13.8 alone until we have a reason to change it since the words "or higher"
just mean whichever version you can install easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
