mbeckerle commented on code in PR #917:
URL: https://github.com/apache/daffodil/pull/917#discussion_r1080655612
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/TypeCalculator.scala:
##########
@@ -153,7 +153,7 @@ class KeysetValueTypeCalculatorOrdered(valueMap:
HashMap[DataValuePrimitive, Dat
})
ans1 match {
case None => {
- (DataValue.NoValue, One(s"Key ${x} not found in enumeration
key-value mapping"))
+ (DataValue.NoValue, One(s"Key ${x} not found in enumeration
dfdlx:repValues keyset-value mapping"))
Review Comment:
I suggest drop the words Key and Keyset entirely, if you want them in the
message for compatiblity reasons add literally "\n(formerly keyset-value
mapping)" at the end of the message, but don't otherwise use this terminology.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
