jadams-tresys commented on code in PR #917:
URL: https://github.com/apache/daffodil/pull/917#discussion_r1081894617
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/TypeCalculator.scala:
##########
@@ -163,7 +163,7 @@ class KeysetValueTypeCalculatorOrdered(valueMap:
HashMap[DataValuePrimitive, Dat
override def outputTypeCalc(x: DataValuePrimitive, xType: NodeInfo.Kind):
(DataValuePrimitiveNullable, Maybe[Error]) = {
unparseMap.get(x) match {
case Some(v) => (v, Maybe.Nope)
- case None => (DataValue.NoValue, One(s"Value ${x} not found in
keyset-value mapping"))
+ case None => (DataValue.NoValue, One(s"Value ${x} not found in
enumeration dfdlx:repValues"))
Review Comment:
You are right that they should be reversed. Had the order mixed up in my
head. They aren't identical as on the inputTypeCalc side we are looking for a
repValue and the outputTypeCalc side we are looking at the enumeration value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
