stevedlawrence commented on code in PR #918:
URL: https://github.com/apache/daffodil/pull/918#discussion_r1081226503
##########
daffodil-core/src/main/scala/org/apache/daffodil/grammar/ElementBaseGrammarMixin.scala:
##########
@@ -103,6 +103,14 @@ trait ElementBaseGrammarMixin
lazy val prefixedLengthElementDecl: PrefixLengthQuasiElementDecl =
LV('prefixedLengthElementDecl){
Assert.invariant(lengthKind == LengthKind.Prefixed)
+ optPrimType match {
+ case Some(primType) => primType match {
+ case PrimType.Integer | PrimType.NonNegativeInteger if lengthUnits ==
LengthUnits.Bits =>
Review Comment:
Is this check necessary here? I would expect a prefixed length quasi element
would eventually end up hitting the other change below at some point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
