mike-mcgann commented on code in PR #918:
URL: https://github.com/apache/daffodil/pull/918#discussion_r1081304151
##########
daffodil-core/src/main/scala/org/apache/daffodil/grammar/ElementBaseGrammarMixin.scala:
##########
@@ -546,7 +554,13 @@ trait ElementBaseGrammarMixin
private def explicitBinaryLengthInBits() = {
val lengthFromProp: JLong = repElement.lengthEv.optConstant.get
val nbits = repElement.lengthUnits match {
- case LengthUnits.Bits => lengthFromProp.longValue()
+ case LengthUnits.Bits => repElement.primType match {
+ case PrimType.Integer | PrimType.NonNegativeInteger => {
+ SDW(WarnID.DeprecatedTypeUse, "In a future release,
lengthUnits='bits' will only be supported for integer types of 64 bits or less")
Review Comment:
Updated message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
