scholarsmate commented on code in PR #440:
URL: https://github.com/apache/daffodil-vscode/pull/440#discussion_r1093304529
##########
src/omega_edit/client.ts:
##########
@@ -69,8 +94,13 @@ export function activate(ctx: vscode.ExtensionContext) {
ctx.subscriptions.push(
vscode.commands.registerCommand(
'omega_edit.version',
- async (startServer: boolean = true) => {
- await commonOmegaEdit(ctx, startServer, omegaEditPackageVersion)
+ async (
+ startServer: boolean = true,
+ port: number | undefined = undefined
+ ) => {
+ port = await getOmegaEditPort(port)
+ initOmegaEditClient('127.0.0.1', port.toString())
+ await commonOmegaEdit(ctx, startServer, omegaEditPackageVersion, port)
return await omegaEditVersion.getVersion()
Review Comment:
This is invisible to the end-user using the GUI. Should put the version in
an info message as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
