scholarsmate commented on code in PR #440:
URL: https://github.com/apache/daffodil-vscode/pull/440#discussion_r1093313939
##########
src/omega_edit/utils.ts:
##########
@@ -138,14 +144,29 @@ export async function viewportSubscribe(
export async function startOmegaEditServer(
ctx: vscode.ExtensionContext,
rootPath: string,
- omegaEditPackageVersion: string
+ omegaEditPackageVersion: string,
+ port: number
): Promise<[vscode.Terminal, boolean]> {
const [scriptName, scriptPath] = await omegaEditServer.setupServer(
rootPath,
omegaEditPackageVersion,
ctx.asAbsolutePath('./node_modules/omega-edit')
)
- let terminal = await runScript(scriptPath, scriptName)
+ process.env.OMEGA_EDIT_SERVER_PORT = port.toString()
+
+ let terminal = await runScript(
Review Comment:
`let` could be `const` here. Would it be worth sending the UI an info/warn
message about the server starting up successfully or not? If there is a
message, we can use that when automating the GUI tests to see if the server was
started successfully or not. Getting access to the terminal output has been a
challenge to get in the GUI tests, so messages will make it more robust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
