mbeckerle commented on PR #947: URL: https://github.com/apache/daffodil/pull/947#issuecomment-1418271105
> > A comma followed by a closing parenthesis... to my eye that's a syntax error and I'm immediately thinking what got cut out by accident and where did it go. > > However, that's also a good point. The Scala guide itself says never to use trailing commas followed by a closing parenthesis on the same line for that same reason. Scalafmt must always place the closing parenthesis on the next line indented closer to the left than the list items so that we can visually see that the list is closed and finished. I withdraw my objection to this based on the added comma being only in multi-line forms, and never immediately preceding a parenthesis on the same line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
