tuxji commented on code in PR #947:
URL: https://github.com/apache/daffodil/pull/947#discussion_r1096007181
##########
daffodil-cli/src/main/scala/org/apache/daffodil/InfosetTypes.scala:
##########
@@ -643,7 +653,12 @@ case class SAXInfosetHandler(dataProcessor: DataProcessor,
forPerformance: Boole
def replay(h: ContentHandler): Unit = h.startDocument()
}
- case class SaxEventStartElement(uri: String, localName: String, qName:
String, atts: Attributes) extends SaxEvent {
+ case class SaxEventStartElement(
+ uri: String,
+ localName: String,
+ qName: String,
+ atts: Attributes)
+ extends SaxEvent {
def replay(h: ContentHandler): Unit = h.startElement(uri, localName,
qName, atts)
}
Review Comment:
> I've enabled rewrite.trailingCommas.style = always.
It looks like scalafmt doesn't adds a trailing comma to the last
constructor/method parameter despite what `rewrite.trailingCommas.style=always`
says. That's a shame because now the extends clause and the def statement have
nothing visually separating them anymore. If scalafmt had added the trailing
comma to the last parameter, the ) and the extend clause would be on the same
line and there would be a clear visual separation:
```scala
case class SaxEventStartElement(
uri: String,
localName: String,
qName: String,
atts: Attributes,
) extends SaxEvent {
def replay(h: ContentHandler): Unit = h.startElement(uri, localName,
qName, atts)
}
```
That's all I have time to review today, but that should be enough for a new
round of changes once you get comments from Mike or other interested parties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
