stevedlawrence commented on code in PR #976:
URL: https://github.com/apache/daffodil/pull/976#discussion_r1123566879
##########
daffodil-test/src/test/resources/org/apache/daffodil/section06/entities/Entities.tdml:
##########
@@ -495,7 +495,7 @@ is multiple bytes in UTF-8 encoding that is used -
DFDL-6-042R"
is multiple bytes in UTF-8 encoding that is used"
model="Entities_01-Embedded.dfdl.xsd" root="seq_10" roundTrip="false">
<tdml:document>
- <tdml:documentPart type="byte">30 ab 31 32 32 7f</tdml:documentPart>
+ <tdml:documentPart type="byte">30 c2 ab 31 32 32 7f</tdml:documentPart>
Review Comment:
I'm not sure if this is the right change. The schema has this for the first
element:
```xml
<xs:element name="e1" type="xs:int" dfdl:terminator="%#rab;" />
```
So the terminator should be the single raw byte `0xab`. According to
DAFFODIL-258, raw byte entities aren't implemented.
So I don't think this issue will be resolved until we fixed DAFFODIL-258.
We might even want to considering creating an SDE or subsetError if raw byte
entities aren't used, since they are clearly broken and they break in subtle
ways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
