mike-mcgann commented on code in PR #976:
URL: https://github.com/apache/daffodil/pull/976#discussion_r1123622655
##########
daffodil-test/src/test/resources/org/apache/daffodil/section06/entities/Entities.tdml:
##########
@@ -495,7 +495,7 @@ is multiple bytes in UTF-8 encoding that is used -
DFDL-6-042R"
is multiple bytes in UTF-8 encoding that is used"
model="Entities_01-Embedded.dfdl.xsd" root="seq_10" roundTrip="false">
<tdml:document>
- <tdml:documentPart type="byte">30 ab 31 32 32 7f</tdml:documentPart>
+ <tdml:documentPart type="byte">30 c2 ab 31 32 32 7f</tdml:documentPart>
Review Comment:
So if that was `dfdl:terminator="«%#rab;"`, the element would have to be
scanned, byte by byte, until finding `c2 ab ab` and, once found, all bytes
scanned would then be decoded to UTF-8? Or would it be better to change the
representation to binary at that point?
I've updated DAFFODIL-2102 to put a link to a blocking ticket to
DAFFODIL-258. Since DAFFODIL-258 does not have a fix version of 3.5.0, should
we remove the fix version from DAFFODIL-2102 as well? I'll close this ticket as
it is part of a larger amount of work not scheduled for the upcoming release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
