mike-mcgann commented on code in PR #985:
URL: https://github.com/apache/daffodil/pull/985#discussion_r1131652870
##########
daffodil-test/src/test/scala/org/apache/daffodil/section00/general/TestDisallowDocType.scala:
##########
@@ -87,7 +86,7 @@ class TestDisallowDocType {
}
@Test def test_infosetFileMustNotHaveDocType(): Unit = {
- val e = intercept[TDMLException] {
+ val e = intercept[SAXParseException] {
Review Comment:
It still needs to stop execution on the fatal error here or it will get
caught in the infinite loop. I originally had fatalError throwing an SDE but
then I found out the TDML runner installs its own custom error handler. So, to
mimic the same behavior I tried to throw an SDE in that runner but it appears
that the concrete implementations of those are in runtime1 and not lib. That is
why I left it as a SAXParseException. Should the TDML runner catch any unhanded
SAXParseExceptions and wrap them in TDMLExceptions or is there a better way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
