stevedlawrence commented on code in PR #985:
URL: https://github.com/apache/daffodil/pull/985#discussion_r1131661855
##########
daffodil-test/src/test/scala/org/apache/daffodil/section00/general/TestDisallowDocType.scala:
##########
@@ -87,7 +86,7 @@ class TestDisallowDocType {
}
@Test def test_infosetFileMustNotHaveDocType(): Unit = {
- val e = intercept[TDMLException] {
+ val e = intercept[SAXParseException] {
Review Comment:
> Should the TDML runner catch any unhanded SAXParseExceptions and wrap
them in TDMLExceptions or is there a better way?
It probably depends where the errors are coming from. If the errors are from
compiling a DFDL schema used by a TDML test, those error should all end up as
`Diagnositc`s that the TDML runner can look for. If they are coming from
something else (e.g. TDMLRunner validating a .tdml file), then it probably
wants to be caught and turned into a TDML exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
