stevedlawrence commented on code in PR #992:
URL: https://github.com/apache/daffodil/pull/992#discussion_r1144811336
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/processors/DataProcessor.scala:
##########
@@ -295,6 +306,7 @@ class DataProcessor(
variableMap = ssrd.originalVariables, // reset to original variables
defined in schema
validationMode =
ValidationMode.Off, // explicitly turn off, so restored processor
won't be validating
+ diagnostics = Seq.empty,
Review Comment:
Might be worth adding a comment like the other ones so we document that we
are just dropping warnings.
##########
daffodil-test/src/test/resources/org/apache/daffodil/section13/text_number_props/TextNumberProps.tdml:
##########
@@ -3719,7 +3719,7 @@
<tdml:errors>
<tdml:error>Schema Definition Error</tdml:error>
<tdml:error>textStandardExponentRep</tdml:error>
- <tdml:error>cannot</tdml:error>
+ <tdml:error>disallowed</tdml:error>
Review Comment:
Weird, another diagnostics change?
##########
daffodil-test/src/test/resources/org/apache/daffodil/section23/dfdl_expressions/expressions.tdml:
##########
@@ -7253,8 +7253,7 @@
<tdml:document>1,2,3</tdml:document>
<tdml:errors>
<tdml:error>Schema Definition Error</tdml:error>
- <tdml:error>Statically ambiguous or query-style paths not
supported</tdml:error>
- <tdml:error>ex:a</tdml:error>
+ <tdml:error>Path step 'ex:{http://example.com}a' ambiguous</tdml:error>
Review Comment:
This change in diagnostics is odd. Do you know why this happened?
I wonder if the statically ambiguous message still exists as a
`tdml:warning`?
Note that the TDMLRunner saves and reloads processors to make sure
saving/reload works, so with this change warnings no longer show up when
reloading. I wonder if when we reloaded previous to this change if the
TDMLRunner incorrectly saw those reloaded warnings as errors? And now that
those warnings don't show up on reload things are different and this will
actually try to parse, and leads to this path step ambiguous error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
