tuxji commented on code in PR #992:
URL: https://github.com/apache/daffodil/pull/992#discussion_r1148440152
##########
daffodil-test/src/test/resources/org/apache/daffodil/section23/dfdl_expressions/expressions.tdml:
##########
@@ -7253,8 +7253,7 @@
<tdml:document>1,2,3</tdml:document>
<tdml:errors>
<tdml:error>Schema Definition Error</tdml:error>
- <tdml:error>Statically ambiguous or query-style paths not
supported</tdml:error>
- <tdml:error>ex:a</tdml:error>
+ <tdml:error>Path step 'ex:{http://example.com}a' ambiguous</tdml:error>
Review Comment:
I agree with @stevedlawrence's suggestion to remove
`processor.getDiagnostics` calls and get diagnostics from the `CompileResult`,
`TDMLParseResult`, and `TDMLUnparseResult` instead. When I implemented the
`TDMLDFDLProcessor` API in `DaffodilCTDMLDFDLProcessor`, I already made its
`isError` and `getDiagnostics` no-ops:
```scala
// We return errors and diagnostics in TDMLParseResult and
TDMLUnparseResult
override def isError: Boolean = false
override def getDiagnostics: Seq[Diagnostic] = Seq.empty
```
These bigger changes may break some tests, but it should be worth fixing
some tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
