shanedell commented on code in PR #666:
URL: https://github.com/apache/daffodil-vscode/pull/666#discussion_r1232437934
##########
server/core/src/main/scala/org.apache.daffodil.debugger.dap/DAPodil.scala:
##########
@@ -382,10 +387,10 @@ class DAPodil(
.variables(DAPodil.VariablesReference(args.variablesReference))
.fold(
Logger[IO]
- .warn(
+ .error(
show"couldn't find variablesReference
${args.variablesReference} in stack ${data}"
) *> // TODO: handle better
- session.sendResponse(request.respondFailure())
+ session.terminate(s"couldn't find variablesReference
${args.variablesReference} in stack ${data}")
Review Comment:
So in this instance should this just be a warn in the log and not cause the
debugger to exit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
