shanedell commented on PR #666: URL: https://github.com/apache/daffodil-vscode/pull/666#issuecomment-1594991266
@mbeckerle You commented a lot on the areas on where I run a `.terminate`. So even without that and using the `respondFailure` would cause the session to end and the debugger to exit. So here that is basically what `.terminate` is doing but without causing the extension to show a blocking dialog. I would be okay with renaming `terminate` to `abort` and having it take a `event: DebugEvent`. I also can make more specific debug event classes in both the debugger and extension so they are more verbose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
