mbeckerle commented on code in PR #696:
URL: https://github.com/apache/daffodil-vscode/pull/696#discussion_r1261122221
##########
server/core/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala:
##########
@@ -99,25 +102,17 @@ object Parse {
}
val parse =
- IO.interruptibleMany {
- val parse_res = dp.parse(
+ IO.interruptibleMany(
Review Comment:
I am going to need to study these IO libraries. I can't say I understand
this code without understanding the cats effects stuff. I've never used these.
What is the "Many" suffix here meaning? I think I get IO.interruptable, but
why "Many" ?
##########
server/core/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala:
##########
@@ -99,25 +102,17 @@ object Parse {
}
val parse =
- IO.interruptibleMany {
Review Comment:
Above at Line 95 is a magic number 4096. Why is that number ok? Needs a
comment at minimum, would be better to `def lineLengthLimitOrWhateverThisIs =
4096` to make it self documenting.
##########
server/core/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala:
##########
@@ -989,7 +985,7 @@ object Parse {
schemaLocation: SchemaFileLocation,
pointsOfUncertainty: List[PointOfUncertainty],
delimiterStack: List[Delimiter],
- diagnostics: List[Diagnostic]
+ diagnostics: List[org.apache.daffodil.api.Diagnostic]
Review Comment:
Why did you not import this and just use Diagnostic? Is there a conflicting
class?
I answered my own question: the SAPI Diagnostic class conflicts. I think
this code makes it pretty clear that SAPI is not complete enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
