arosien commented on code in PR #696:
URL: https://github.com/apache/daffodil-vscode/pull/696#discussion_r1261638513


##########
server/core/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala:
##########
@@ -989,7 +985,7 @@ object Parse {
         schemaLocation: SchemaFileLocation,
         pointsOfUncertainty: List[PointOfUncertainty],
         delimiterStack: List[Delimiter],
-        diagnostics: List[Diagnostic]
+        diagnostics: List[org.apache.daffodil.api.Diagnostic]

Review Comment:
   Correct: `PState` contains `api.Diagnostics`, whereas it seemed better in 
the DAP debugger backend to use `sapi.Diagnostics` for state.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to