stevedlawrence commented on code in PR #749:
URL: https://github.com/apache/daffodil-vscode/pull/749#discussion_r1287711405
##########
debugger/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala:
##########
@@ -63,7 +62,7 @@ trait Parse {
object Parse {
implicit val logger: Logger[IO] = Slf4jLogger.getLogger
- case class Exception(diagnostics: List[Diagnostic])
+ case class Exception(diagnostics: List[org.apache.daffodil.sapi.Diagnostic])
Review Comment:
Why not import sapi.Diagnostic?
##########
package.json:
##########
@@ -3,7 +3,7 @@
"displayName": "Apache Daffodil™ Extension for Visual Studio Code",
"description": "Apache Daffodil™ Extension for Visual Studio Code providing
DFDL syntax highlighting, DFDL code completion, DFDL schema debugging, and data
editor",
"version": "1.3.0",
- "daffodilVersion": "3.4.0",
+ "daffodilVersion": "3.5.0",
Review Comment:
Daffodil had some license updates for 3.5.0. I think some or all of these
need to get pulled into the debugger license files? Here's a command to show
the changes to the Daffodil license files:
```
git diff v3.4.0 v3.5.0 -- LICENSE NOTICE daffodil-cli/bin.LICENSE
daffodil-cli/bin.NOTICE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
