stevedlawrence commented on code in PR #749: URL: https://github.com/apache/daffodil-vscode/pull/749#discussion_r1289065792
########## package.json: ########## @@ -3,7 +3,7 @@ "displayName": "Apache Daffodil™ Extension for Visual Studio Code", "description": "Apache Daffodil™ Extension for Visual Studio Code providing DFDL syntax highlighting, DFDL code completion, DFDL schema debugging, and data editor", "version": "1.3.0", - "daffodilVersion": "3.4.0", + "daffodilVersion": "3.5.0", Review Comment: Some of the changes may be relevant. The Daffodil CLI license files are a good reference because they include the license information of all libraries that Daffodil depends on (since the CLI bundles all those libraries). So if you depend on Daffodil, it's likely you also depend on and include those same libraries and need to copy the license information. Some exceptions are for libraries that are specific to the CLI like jline, jansi, and scallop that you likely don't depend on and don't need to include. And if you exclude libraries Daffodil depends on then you also don't need those. But for example, the CLI pulls in jackson core for json support. The jackson license/notice changed, so unless the vscode debugger excludes that or doesn't pull it in, then you need to include those updates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
