stevedlawrence commented on code in PR #1085: URL: https://github.com/apache/daffodil/pull/1085#discussion_r1326002402
########## daffodil-lib/src/main/scala/org/apache/daffodil/lib/cookers/Cookers.scala: ########## @@ -101,8 +101,6 @@ object ChoiceDispatchKeyCooker extends StringLiteralNonEmptyNoCharClassEntitiesN object ChoiceBranchKeyCooker extends ListOfStringLiteralNonEmptyNoCharClassEntitiesNoByteEntities() -object RepValueCooker extends ListOfStringLiteralNonEmptyNoCharClassEntitiesNoByteEntities() Review Comment: I think I can actually bring back the cooker. I thought this cooked everything to a BigInt and so avoided it (one of the updates in the PR is to use the correct DataPrimitive type). But I now see it just cooks to a list of strings. This is better than the `.split` stuff I do elsewhere. I'll give it a shot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
