stevedlawrence commented on code in PR #1085: URL: https://github.com/apache/daffodil/pull/1085#discussion_r1326031752
########## daffodil-lib/src/main/scala/org/apache/daffodil/lib/cookers/Cookers.scala: ########## @@ -101,8 +101,6 @@ object ChoiceDispatchKeyCooker extends StringLiteralNonEmptyNoCharClassEntitiesN object ChoiceBranchKeyCooker extends ListOfStringLiteralNonEmptyNoCharClassEntitiesNoByteEntities() -object RepValueCooker extends ListOfStringLiteralNonEmptyNoCharClassEntitiesNoByteEntities() Review Comment: > Follow up. I've never seen it, but are our repValues integers nonNegative only, or can things like -1 -2, etc. be enum repValues? The code currently allows anything derived from xs:integer, so signed types should work as well. I'll add a test or two to make sure it works as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
