stevedlawrence commented on code in PR #1057:
URL: https://github.com/apache/daffodil/pull/1057#discussion_r1342851003
##########
project/Dependencies.scala:
##########
@@ -63,4 +63,17 @@ object Dependencies {
lazy val exi = Seq(
"com.siemens.ct.exi" % "exificient" % "1.0.7",
)
+
+ lazy val xjc =
Review Comment:
The xjc dependencies are fine, but CDDL is category B we do need to mention
CDDL so needs to be mentioned in a readme.
We already depend on scala-xml and scala-parser-combinators. LGPL is
category X and is not allowed by ASF, but I don't think it's a mandatory
dependency. Dispatch http looks like an http communication library library that
scalaxb can generate code to support, but it looks optional to me. For example,
I think it can be disabled with:
```scala
Compile / scalaxb / scalaxbGenerateDispatchClient := false
```
Similarly scalaxb also supports http4s and gigahorse, which I think are also
optional with similar keys to disabled (disabled by default). I'm also not
sure where scalaxb actually uses the jaxb-api. I don't see it mentioned in the
generated code. Maybe that's some an optional dependency as well?
But either way I think we're fine, we just need to make sure to update
LICENSE/NOTICE appropriately if CDDL is included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
