arosien commented on PR #1057: URL: https://github.com/apache/daffodil/pull/1057#issuecomment-1934915794
> I think this could just use a bit more extensive test, and maybe some license questions? > > Also, it looks like you squashed into a single commit, but it still needs to be rebased to fix conflicts. > > Also, can you update the commit message to include a bug reference, right now it has a broken link. I think [DAFFODIL-2830](https://issues.apache.org/jira/browse/DAFFODIL-2830) is the right bug? I don't know why it says build.sbt has conflicts, locally I don't see them. I'll poke around more. Will update the bug reference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
