stricklandrbls commented on code in PR #883:
URL: https://github.com/apache/daffodil-vscode/pull/883#discussion_r1432199677
##########
src/dataEditor/dataEditorClient.ts:
##########
@@ -459,11 +459,17 @@ export class DataEditorClient implements
vscode.Disposable {
case MessageCommand.undoChange:
await undo(this.omegaSessionId)
await this.sendChangesInfo()
+ this.panel.webview.postMessage({
Review Comment:
I'm on github mobile and have to poke around to see what this is
referencing. I'll get back to you soon.
This is because the clear changes command will clear the changes that were
made in the data editor and in turn clear the data stores that the byte
highlighting is derived from.
The naming convention does seem a bit confusing but the
`this.sendChangesInfo()` is sending "changes" in regards to the difference in
changes made from Data Editor viewport edits and the associated file on this.
Whereas, the webview message `clearChanges` clears uncommitted changes / edit
from a user's selection from within the data editor.
I think they could both use a bit more expressive names:
`sendUpdatedFileInfo` and `clearUnsavedActivity` perhaps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
