scholarsmate commented on PR #883: URL: https://github.com/apache/daffodil-vscode/pull/883#issuecomment-1838761034
The Search function isn't working properly: As we navigate using the "seek to next match", we start seeing incorrect matches being highlighted. <img width="1598" alt="Screenshot 2023-12-04 at 09 26 26" src="https://github.com/apache/daffodil-vscode/assets/2205472/22fa95dc-b406-4cf7-b1c1-ed75db2d5ee5";> It gets worse as we get to the last match. <img width="1479" alt="Screenshot 2023-12-04 at 09 26 06" src="https://github.com/apache/daffodil-vscode/assets/2205472/dc16296e-39b7-4f78-adcd-b01c383af31e";> The warning text is jumbled up. <img width="924" alt="Screenshot 2023-12-04 at 09 24 17" src="https://github.com/apache/daffodil-vscode/assets/2205472/34c3abd2-454a-4b52-9301-060a7db10161";> This is neat though that it can handle overlapping highlghts. <img width="1335" alt="Screenshot 2023-12-04 at 09 25 16" src="https://github.com/apache/daffodil-vscode/assets/2205472/eef0bac4-b0a6-4601-9081-00eec1828c4c";> To reproduce, just open `package.json` and search for `Apache`. You can see that no changes were made yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
