mbeckerle commented on code in PR #1139:
URL: https://github.com/apache/daffodil/pull/1139#discussion_r1449198500
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/grammar/primitives/PrimitivesTextNumber.scala:
##########
@@ -586,6 +597,29 @@ case class ConvertTextStandardNumberPrim(e: ElementBase)
Nope
}
+ // ICU does not have a way to set the pad position to after an affix if
the positive pattern
+ // does not have that affix. For example, "* 0", will always have a pad
position of
Review Comment:
Needs release note. This is a backward incompatible change (very minor one)
because a "*0" in the negative pattern would have been always ignored before,
but now means something that changes the behavior.
The warnings suggested in
[DAFFODIL-2870](https://issues.apache.org/jira/browse/DAFFODIL-2870) are still
meaningful, they just need to allow for the cases where the pad specifier in
the negative pattern is used rather than ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
