stevedlawrence commented on code in PR #1139:
URL: https://github.com/apache/daffodil/pull/1139#discussion_r1453723699
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/grammar/primitives/PrimitivesTextNumber.scala:
##########
@@ -586,6 +597,29 @@ case class ConvertTextStandardNumberPrim(e: ElementBase)
Nope
}
+ // ICU does not have a way to set the pad position to after an affix if
the positive pattern
+ // does not have that affix. For example, "* 0", will always have a pad
position of
Review Comment:
The convention we've been using so far is to add the string
`Deprecation/Compatibility:` (or something similar) to the end of the commit
message, followed by the message that should be added to release notes. Here's
the commit message for this PR where the update can be seen:
https://github.com/apache/daffodil/pull/1139/commits/87f3b8940cb0e66c7cdf25fb9306ac19950a13d4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
