arosien commented on code in PR #935:
URL: https://github.com/apache/daffodil-vscode/pull/935#discussion_r1449529763


##########
package.json:
##########
@@ -340,6 +340,16 @@
                 "description": "Absolute path to the input data file.",
                 "default": "${command:AskForDataName}"
               },
+              "rootName": {

Review Comment:
   Concern: I kind of wish we could refactor the `schema` configuration as an 
object so that these properties are not all at the "root" level. But that would 
require breaking existing configuration formats.
   
   Something like:
   ```json
   "schema": {
     "path": ...,
     "rootName": ...,
     "rootNamespace": ...
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to