shanedell commented on code in PR #935:
URL: https://github.com/apache/daffodil-vscode/pull/935#discussion_r1449555804


##########
debugger/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala:
##########
@@ -472,6 +492,28 @@ object Parse {
           }
       }
 
+    // Parse the root name field from the launch config
+    // Defaults to None
+    //
+    // arguments: Launch config
+    def parseRootName(arguments: JsonObject) =
+      Option(arguments.getAsJsonPrimitive("rootName"))
+        .map(_.getAsString())
+        .getOrElse("")
+        .asRight[String]
+        .toEitherNel

Review Comment:
   @arosien So I tried that but I am getting these errors:
   
   ```bash
   [error] 
/Users/sdell/apache/daffodil-vscode/debugger/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala:295:18:
 could not find implicit value for parameter p: 
cats.NonEmptyParallel[[+A]scala.util.Either[java.io.Serializable,A]]
   [error]         ).parMapN(LaunchArgs.Manual.apply)
   [error]                  ^
   [error] 
/Users/sdell/apache/daffodil-vscode/debugger/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala:326:20:
 could not find implicit value for parameter p: 
cats.NonEmptyParallel[[+A]scala.util.Either[java.io.Serializable,A]]
   [error]           ).parMapN(LaunchArgs.Manual.apply)
   [error]                    ^
   [error] 
/Users/sdell/apache/daffodil-vscode/debugger/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala:343:24:
 could not find implicit value for parameter p: 
cats.NonEmptyParallel[[+A]scala.util.Either[java.io.Serializable,A]]
   [error]               ).parMapN(LaunchArgs.TDMLConfig.Generate.apply)
   [error]                        ^
   [error] 
/Users/sdell/apache/daffodil-vscode/debugger/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala:358:24:
 could not find implicit value for parameter p: 
cats.NonEmptyParallel[[+A]scala.util.Either[java.io.Serializable,A]]
   [error]               ).parMapN(LaunchArgs.TDMLConfig.Append.apply)
   [error]                        ^
   [error] 
/Users/sdell/apache/daffodil-vscode/debugger/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala:371:24:
 could not find implicit value for parameter p: 
cats.NonEmptyParallel[[+A]scala.util.Either[java.io.Serializable,A]]
   [error]               ).parMapN(LaunchArgs.TDMLConfig.Execute.apply)
   [error]                        ^
   [error] 
/Users/sdell/apache/daffodil-vscode/debugger/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala:503:9:
 polymorphic expression cannot be instantiated to expected type;
   [error]  found   : [A, AA >: A]cats.data.EitherNel[AA,Option[String]]
   [error]     (which expands to)  [A, AA >: 
A]scala.util.Either[cats.data.NonEmptyList[AA],Option[String]]
   [error]  required: Either[String,Option[String]]
   [error]       ).toEitherNel
   [error]         ^
   [error] 
/Users/sdell/apache/daffodil-vscode/debugger/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala:513:9:
 polymorphic expression cannot be instantiated to expected type;
   [error]  found   : [A, AA >: A]cats.data.EitherNel[AA,Option[String]]
   [error]     (which expands to)  [A, AA >: 
A]scala.util.Either[cats.data.NonEmptyList[AA],Option[String]]
   [error]  required: Either[String,Option[String]]
   [error]       ).toEitherNel
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to