shanedell commented on code in PR #990:
URL: https://github.com/apache/daffodil-vscode/pull/990#discussion_r1521730422
##########
debugger/src/main/scala/org.apache.daffodil.debugger.dap/DAPodil.scala:
##########
@@ -748,11 +748,24 @@ object DAPodil extends IOApp {
copy(value = value + (uri.normalize -> lines))
def contains(location: Location): Boolean =
- value.exists {
- // format: off
- case (uri, lines) =>
- uri == location.uri && lines.exists(_ == location.line)
- // format: on
+ value.exists { case (uri, lines) =>
Review Comment:
@mbeckerle Okay so would something like
`debugger/src/main/scala/org.apache.daffodil.debugger.dap/Portability.scala`
work for that file? I believe this will be permanent work around because the
`location.uri` is what produces the URI like `file:/Users/user/path.file`,
which I believe should be created/initialized in the Scala somewhere as
`java.net.URI`. But the URI passed in from the extension is coming in like
`file:///Users/user/path.file`.
However, I could also use `getPath` or `getRawPath` to use for comparisons
instead. This would eliminate the need for caring about if the URI starts with
`file://` or `file:`, also eliminating the `replace("file://", "file:")`. But
in the case of windows it would still need the fix of making the drive letter
uppercase.
This fix may be needed else where but I would need to do more thorough check
to know for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
