shanedell commented on code in PR #990:
URL: https://github.com/apache/daffodil-vscode/pull/990#discussion_r1521842669
##########
debugger/src/main/scala/org.apache.daffodil.debugger.dap/DAPodil.scala:
##########
@@ -748,11 +748,24 @@ object DAPodil extends IOApp {
copy(value = value + (uri.normalize -> lines))
def contains(location: Location): Boolean =
- value.exists {
- // format: off
- case (uri, lines) =>
- uri == location.uri && lines.exists(_ == location.line)
- // format: on
+ value.exists { case (uri, lines) =>
Review Comment:
@arosien Yes the main issue that one URI used an uppercase drive letter and
the other used lowercase. So if we just compare the paths we avoid any issues
with the different way that the URI's start with `file:`, which may not be an
issue any way I am not sure. But we want to use the paths so we know the index
of where the drive letter will be in a split array. Basically, to fix the drive
letter issue we need to split the path and either uppercase or lowercase the
drive letter. I think normally uppercase is Windows default so that is what I
planned to use.
##########
debugger/src/main/scala/org.apache.daffodil.debugger.dap/DAPodil.scala:
##########
@@ -748,11 +748,24 @@ object DAPodil extends IOApp {
copy(value = value + (uri.normalize -> lines))
def contains(location: Location): Boolean =
- value.exists {
- // format: off
- case (uri, lines) =>
- uri == location.uri && lines.exists(_ == location.line)
- // format: on
+ value.exists { case (uri, lines) =>
Review Comment:
@arosien Yes the main issue is that one URI used an uppercase drive letter
and the other used lowercase. So if we just compare the paths we avoid any
issues with the different way that the URI's start with `file:`, which may not
be an issue any way I am not sure. But we want to use the paths so we know the
index of where the drive letter will be in a split array. Basically, to fix the
drive letter issue we need to split the path and either uppercase or lowercase
the drive letter. I think normally uppercase is Windows default so that is what
I planned to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
