shanedell commented on code in PR #990:
URL: https://github.com/apache/daffodil-vscode/pull/990#discussion_r1530560739


##########
debugger/src/main/scala/org.apache.daffodil.debugger.dap/DAPodil.scala:
##########
@@ -748,11 +748,24 @@ object DAPodil extends IOApp {
       copy(value = value + (uri.normalize -> lines))
 
     def contains(location: Location): Boolean =
-      value.exists {
-        // format: off
-        case (uri, lines) =>
-          uri == location.uri && lines.exists(_ == location.line)
-        // format: on
+      value.exists { case (uri, lines) =>

Review Comment:
   > @mbeckerle Would the suggested changes from [#990 
(comment)](https://github.com/apache/daffodil-vscode/pull/990#discussion_r1521780315)
 be good to to fix the issue and get this PR merged?
   
   Hey @mbeckerle just checking back in on this PR as the changes you mentioned 
will be the main thing holding it from getting merged. So will the fix I 
mentioned work?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to