shanedell commented on code in PR #1010:
URL: https://github.com/apache/daffodil-vscode/pull/1010#discussion_r1581208156


##########
.github/workflows/CI.yml:
##########
@@ -134,6 +134,10 @@ jobs:
         os: [ macos-12, ubuntu-20.04, windows-2019 ]
         node: [ '16', '18' ]
         vscode: [ 'stable' ]
+        # latest version of daffodil doesn't seem to work on windows-2019 
running node 18
+        exclude:
+          - os: windows-2019
+            node: 18

Review Comment:
   Yeah I agree. Some of the nightly tests are outliers where they kind of fail 
randomly due to network issues such as not being able to install yarn packages 
or something. The main issue I am seeing is that commands are not becoming 
available for Windows when using NodeJS 18. I am not sure why, I will have to 
do testing in a VM to see if I can reproduce the issue. Hopefully this will 
help me find the issue and fix it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to