shanedell commented on code in PR #1010:
URL: https://github.com/apache/daffodil-vscode/pull/1010#discussion_r1583327749
##########
.github/workflows/CI.yml:
##########
@@ -134,6 +134,10 @@ jobs:
os: [ macos-12, ubuntu-20.04, windows-2019 ]
node: [ '16', '18' ]
vscode: [ 'stable' ]
+ # latest version of daffodil doesn't seem to work on windows-2019
running node 18
+ exclude:
+ - os: windows-2019
+ node: 18
Review Comment:
@stevedlawrence I was able to find a fix. I booted up a windows VM and
installed nodejs 18.20.2 (current latest of 18). When I did this I had the same
issues as CI, but when I installed the next latest version available on windows
using `choco`, this version being `18.18.2` everything ran fine. So I made the
CI use nodejs 18.20.1 which seems to work fine so there must be a bug between
windows and nodejs 18.20.2 that causes this issue.
I plan to do a little bit more digging to see if I can somehow get 18.20.2
to work but I think I should make that a separate PR in that case. This being
since I may not be able to get it to work and may need to wait for 18.20.3 or
18.21.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
