mbeckerle commented on code in PR #1228:
URL: https://github.com/apache/daffodil/pull/1228#discussion_r1586482595
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/processors/parsers/ElementCombinator1.scala:
##########
@@ -198,6 +197,14 @@ abstract class ElementParserBase(
eAfterParser.get.parse1(pstate)
if (pstate.processorStatus ne Success) return
+
+ val shouldValidate = erd.isSimpleType &&
+ pstate.dataProc.isDefined && pstate.dataProc.value.validationMode !=
ValidationMode.Off
Review Comment:
I think when "full" validation is on, we should not incur the overhead of
'limited' validation, we should leave it up to the Xerces validation at the end
of whole parse.
So this should, I think, look for ValidationMode.Limited specifically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
