stevedlawrence commented on code in PR #1228:
URL: https://github.com/apache/daffodil/pull/1228#discussion_r1586490568
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/processors/parsers/ElementCombinator1.scala:
##########
@@ -198,6 +197,14 @@ abstract class ElementParserBase(
eAfterParser.get.parse1(pstate)
if (pstate.processorStatus ne Success) return
+
+ val shouldValidate = erd.isSimpleType &&
+ pstate.dataProc.isDefined && pstate.dataProc.value.validationMode !=
ValidationMode.Off
Review Comment:
That's a change in behavior that might break some tests? We might have some
tests that set validationMode=full/on but expect specific error messages from
Daffodil's limited validation. But that might be considered a bug in those
tests?
Note we also have a similar check that would need to be changed here:
https://github.com/apache/daffodil/blob/main/daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/processors/parsers/SequenceChildBases.scala#L532-L533.
Might have others as well? So maybe if we want to change the behavior we might
want to create a ticket and do it as as separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
