mbeckerle commented on code in PR #1313:
URL: https://github.com/apache/daffodil/pull/1313#discussion_r1776975907
##########
daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala:
##########
@@ -2262,6 +2262,7 @@ case class Document(d: NodeSeq, parent: TestCase) {
case "byte" => new ByteDocumentPart(child, this)
case "bits" => new BitsDocumentPart(child, this)
case "file" => new FileDocumentPart(child, this)
+ case "" => throw TDMLException("documentPart must have attribute
'type'", None)
Review Comment:
I think it is not a supported use case for the TDML runner to NOT validate
the incoming TDML XML.
Why do we need that even in unit tests? My guess is such tests no longer add
value and we should remove them.
Code *should not* redundantly check things that are assured by XML schema
validity, as it creates confusion about what needs to be checked and what does
not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
