olabusayoT commented on code in PR #1313:
URL: https://github.com/apache/daffodil/pull/1313#discussion_r1777421965
##########
daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala:
##########
@@ -2262,6 +2262,7 @@ case class Document(d: NodeSeq, parent: TestCase) {
case "byte" => new ByteDocumentPart(child, this)
case "bits" => new BitsDocumentPart(child, this)
case "file" => new FileDocumentPart(child, this)
+ case "" => throw TDMLException("documentPart must have attribute
'type'", None)
Review Comment:
Just to check I'm reading that right, the TDML Runner should be validating
incoming TDML? i.e when we do `Runner(xml)` it should validate the incoming
xml. I believe it currently does that.
I updated the code to remove the scala check, but I left in one of the tests
that ensures XML schema vailidity so we could point to that when we closed the
ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
