mbeckerle commented on code in PR #1337:
URL: https://github.com/apache/daffodil/pull/1337#discussion_r1799415881
##########
daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/unparsers/runtime1/BinaryNumberUnparsers.scala:
##########
@@ -93,6 +93,27 @@ abstract class BinaryIntegerBaseUnparser(e:
ElementRuntimeData, signed: Boolean)
dos.putLong(asLong(value), nBits, finfo)
}
}
+
+ override def unparse(state: UState): Unit = {
+ val nBits = getBitLength(state)
Review Comment:
When there is no access to state, I think the technique is to throw a
thin-exception to someplace that catches it that has the state needed to report
the error in context properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
