olabusayoT commented on code in PR #1337:
URL: https://github.com/apache/daffodil/pull/1337#discussion_r1800016020
##########
daffodil-test/src/test/resources/org/apache/daffodil/extensions/enum/enums.tdml:
##########
@@ -134,7 +134,7 @@
</element>
<simpleType name="myBit" dfdl:lengthKind="explicit" dfdl:length="1">
- <restriction base="xs:byte"/>
+ <restriction base="xs:unsignedByte"/>
Review Comment:
> <element name="b" type="xs:byte" dfdl:representation="text"
dfdl:encoding="bits" dfdl:lengthKind="pattern"
> dfdl:lengthPattern=".{0,1}(?=11111111)" />
I'm not sure I follow. In this case, the code changes wouldn't apply since
representation is text, not binary. If we have the following element e1
```xml
<xs:element name="e1">
<xs:complexType>
<xs:sequence>
<xs:element name="b" type="xs:byte" dfdl:representation="text"
dfdl:encoding="X-DFDL-BITS-LSBF"
dfdl:lengthKind="pattern"
dfdl:lengthPattern=".{0,1}(?=11111111)" />
<xs:element name="c" type="xs:string" dfdl:representation="text"
dfdl:encoding="X-DFDL-US-ASCII-7-BIT-PACKED"
dfdl:lengthKind="explicit" dfdl:length="1" />
</xs:sequence>
</xs:complexType>
</xs:element>
```
and the following data: 011111111, it parses fine and you get
```xml
<ex:e1 xmlns:ex="http://example.com";>
<ex:b>0</ex:b>
<ex:c></ex:c>
</ex:e1>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
