shanedell commented on code in PR #1119:
URL: https://github.com/apache/daffodil-vscode/pull/1119#discussion_r1811284636
##########
.github/workflows/CI.yml:
##########
@@ -126,13 +126,13 @@ jobs:
run: $SBT ratCheck || (cat target/rat.txt; exit 1)
build-test-package:
- name: 'Build, Test, and Package (OS: ${{ matrix.os }}, Node: ${{
matrix.node }}, Java: ${{ matrix.java_version }})'
+ name: 'Build, Test, and Package (OS: ${{ matrix.os }}, Node: ${{
matrix.node }}, Java: ${{ matrix.java_version }}, VS Code: ${{ matrix.vscode
}})'
strategy:
matrix:
java_distribution: [ temurin ]
java_version: [ 8, 11, 17 ]
os: [ macos-12, ubuntu-20.04, windows-2019 ]
- node: [ '16', '18.20.1' ] # version 18.20.2 (current latest of 18) is
broken on windows
Review Comment:
Add this back, nodejs 16 is our minimal supported version so we want to make
sure to test it in CI. Also add 20 into this file as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
