shanedell commented on PR #1119: URL: https://github.com/apache/daffodil-vscode/pull/1119#issuecomment-2430414176
> Also replace node 16 with node 20 in CI. > > Fixes #1117. > > Need to upgrade from Node 16 to 18 to work in Electron 30. The spawn call in Node requires that the shell be used for Windows scripts like we're using to start the Ωedit service. That was fixed in Ωedit v0.9.83, which now needs node 18+. > > References: [ctc-oss/omega-edit@70e71dd](https://github.com/ctc-oss/omega-edit/commit/70e71dd48bb88b528b22c9ca209856a2561892b0) https://code.visualstudio.com/updates/v1_92#_electron-30-update https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2#command-injection-via-args-parameter-of-child_processspawn-without-shell-option-enabled-on-windows-cve-2024-27980---high https://nodejs.org/api/child_process.html#spawning-bat-and-cmd-files-on-windows I did not see the part about needing to upgrade from 16 to 18 for spawn call. If that is the case then we can remove 16 but we need to document the minimal version of node will now be 18. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
