olabusayoT commented on code in PR #1337: URL: https://github.com/apache/daffodil/pull/1337#discussion_r1884274051
########## daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/processors/PackedDecimalParsers.scala: ########## @@ -84,11 +84,10 @@ class PackedDecimalPrefixedLengthParser( class PackedIntegerRuntimeLengthParser( val e: ElementRuntimeData, - signed: Boolean, packedSignCodes: PackedSignCodes, val lengthEv: Evaluatable[JLong], val lengthUnits: LengthUnits -) extends PackedBinaryIntegerBaseParser(e, signed) +) extends PackedBinaryIntegerBaseParser(e) Review Comment: So this signed boolean was replaced by the primitives signedness...as we were just passing in true/false depending on whether the primitive was signed or unsigned...the PAckedDecimalParsers never passed in decimalSigned, so that wasn't remove...as @stevedlawrence said I think that's a separate bug -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
