stevedlawrence commented on code in PR #1337: URL: https://github.com/apache/daffodil/pull/1337#discussion_r1884206692
########## daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/processors/PackedDecimalParsers.scala: ########## @@ -84,11 +84,10 @@ class PackedDecimalPrefixedLengthParser( class PackedIntegerRuntimeLengthParser( val e: ElementRuntimeData, - signed: Boolean, packedSignCodes: PackedSignCodes, val lengthEv: Evaluatable[JLong], val lengthUnits: LengthUnits -) extends PackedBinaryIntegerBaseParser(e, signed) +) extends PackedBinaryIntegerBaseParser(e) Review Comment: Does using the signedness of the primitive type work? I think the only time xs:decimalSign should matter is with the primitive type is xs:decimal, which uses the `PackedDecimal*` parsers, not these `PackedInteger*` parsers. So if feels like we do need a signed boolean for `PackedDecimal*` parsers, but I think that's just an existing bug that could maybe be added in a separate PR, since this one is more about ranges of things. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
