mbeckerle opened a new pull request, #1396: URL: https://github.com/apache/daffodil/pull/1396
For now I have left in the TimeTracker.trace calls that measured the performance. I will take those out later. With this change, schema compilation for Link16 drops from 2+ minutes to 18 seconds. Added instrumentation to compiler which shows that most time (by far, like 80+ percent) is spent in Xerces validating each schema file individually. This is unnecessary. We only need to validate the top level schema to detect UPA errors. Fixed other error causing repeated evaluation of OOLAG LV values. DAFFODIL-2965, DAFFODIL-2781 This is the output from the instrumentation before the functional improvements in this change set: ``` [error] [info] validateAsDFDLSchema schemaFactory.newSchema 66.852 59.13% 67187944 995 [error] [info] resolveCommon 9.720 8.60% 17884 543499 [error] [info] loadDocument 6.607 5.84% 6639796 995 [error] [info] validateAsDFDLSchema load 5.858 5.18% 5887291 995 [error] [info] parserFromURI 5.689 5.03% 5717234 995 [error] [info] unparser 3.707 3.28% 1853341986 2 [error] [info] TypeBase 2.866 2.53% 431697 6639 [error] [info] constructingLoader.load 1.705 1.51% 856144 1991 [error] [info] elementRuntimeData 1.651 1.46% 248657 6638 [error] [info] areComponentsConstructed 1.603 1.42% 1602879249 1 [error] [info] compileSourceInternal 1.018 0.90% 1018485705 1 [error] [info] groupMembers 0.628 0.56% 72189 8701 [error] [info] validateXML 0.605 0.54% 608347 995 ``` Here is the instrumentation after: ``` [error] [info] unparser 3.199 21.79% 1599749444 2 [error] [info] TypeBase 1.972 13.43% 297091 6639 [error] [info] areComponentsConstructed 1.696 11.55% 1696149699 1 [error] [info] elementRuntimeData 1.389 9.46% 209236 6638 [error] [info] constructingLoader.load 0.984 6.70% 988328 996 [error] [info] groupMembers 0.646 4.40% 74285 8701 [error] [info] parser 0.490 3.34% 244993274 2 [error] [info] expr 0.427 2.91% 568419 751 [error] [info] DFDLNewVariableInstance_requiredEvaluation_1 0.246 1.68% 2196754 112 [error] [info] compileSourceInternal 0.227 1.55% 227499753 1 [error] [info] repTypeMaps 0.217 1.47% 410835 527 [error] [info] iiSchemaFile 0.197 1.34% 198092 996 [error] [info] encoding 0.177 1.20% 13484 13099 [error] [info] shortFormProperties 0.161 1.10% 7972 20201 [error] [info] nonDefaultPropertySources 0.160 1.09% 8622 18537 [error] [info] resolvedSchemaLocation 0.159 1.08% 40757 3907 [error] [info] notSeenThisBefore 0.141 0.96% 36013 3907 [error] [info] SequenceGroupRef_requiredEvaluation_7 0.124 0.85% 29451 4225 [error] [info] enclosingElements 0.109 0.74% 8547 12726 [error] [info] priorAlignmentApprox 0.099 0.67% 8399 11755 [error] [info] combinedJustThisOneOproperties 0.096 0.65% 4748 20201 [error] [info] longFormProperties 0.091 0.62% 4490 20201 [error] [info] LocalElementDecl_requiredEvaluation_24 0.085 0.58% 13942 6105 [error] [info] defaultPropertySources 0.076 0.52% 4112 18537 [error] [info] hiddenGroupRefOption 0.074 0.50% 13526 5467 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
