mbeckerle commented on code in PR #1396:
URL: https://github.com/apache/daffodil/pull/1396#discussion_r1894374259
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/compiler/Compiler.scala:
##########
@@ -409,9 +410,10 @@ object Compiler {
optRootName: Option[String],
optRootNamespace: Option[String]
): ProcessorFactory = {
- synchronized {
+ val res = synchronized {
Review Comment:
Revert
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/runtime1/SchemaSetRuntime1Mixin.scala:
##########
@@ -48,22 +48,25 @@ trait SchemaSetRuntime1Mixin {
}.value
lazy val parser = LV('parser) {
- val par = if (generateParser) root.document.parser else new
NotParsableParser(root.erd)
+ val par =
+ if (generateParser) root.document.parser
+ else new NotParsableParser(root.erd)
Processor.initialize(par)
par
}.value
lazy val unparser = LV('unparser) {
val unp =
- if (generateUnparser) root.document.unparser else new
NotUnparsableUnparser(root.erd)
+ if (generateUnparser) root.document.unparser
+ else new NotUnparsableUnparser(root.erd)
Processor.initialize(unp)
unp
}.value
private lazy val layerRuntimeCompiler = new LayerRuntimeCompiler
- lazy val allLayers: Seq[LayerRuntimeData] = LV('allLayers) {
- val lrds: Seq[LayerRuntimeData] = self.allSchemaComponents
+ private lazy val allLayers: Seq[LayerRuntimeData] = LV('allLayers) {
+ lazy val lrds: Seq[LayerRuntimeData] = self.allSchemaComponents
Review Comment:
Revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]